-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAP-817 - [CRN][GP2] Cookies - Google Analytics collection issue #4489
Merged
AimeurAmin
merged 1 commit into
master
from
ASAP-817-CRN-GP2-Cookies-Google-Analytics-collection-issue
Dec 23, 2024
Merged
ASAP-817 - [CRN][GP2] Cookies - Google Analytics collection issue #4489
AimeurAmin
merged 1 commit into
master
from
ASAP-817-CRN-GP2-Cookies-Google-Analytics-collection-issue
Dec 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AimeurAmin
force-pushed
the
ASAP-817-CRN-GP2-Cookies-Google-Analytics-collection-issue
branch
from
December 23, 2024 10:54
82f25b9
to
92068ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4489 +/- ##
==========================================
- Coverage 99.48% 99.48% -0.01%
==========================================
Files 1086 1086
Lines 21715 21697 -18
Branches 6866 6848 -18
==========================================
- Hits 21603 21585 -18
Misses 112 112 ☔ View full report in Codecov by Sentry. |
gabiayako
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
AimeurAmin
deleted the
ASAP-817-CRN-GP2-Cookies-Google-Analytics-collection-issue
branch
December 23, 2024 13:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASAP-817