Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP-817 - [CRN][GP2] Cookies - Google Analytics collection issue #4489

Merged

Conversation

AimeurAmin
Copy link
Collaborator

@AimeurAmin AimeurAmin commented Dec 23, 2024

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (739cc27) to head (92068ea).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4489      +/-   ##
==========================================
- Coverage   99.48%   99.48%   -0.01%     
==========================================
  Files        1086     1086              
  Lines       21715    21697      -18     
  Branches     6866     6848      -18     
==========================================
- Hits        21603    21585      -18     
  Misses        112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabiayako gabiayako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AimeurAmin AimeurAmin merged commit 558aa57 into master Dec 23, 2024
63 checks passed
@AimeurAmin AimeurAmin deleted the ASAP-817-CRN-GP2-Cookies-Google-Analytics-collection-issue branch December 23, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants